Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: test_telemetry_queue_buffer_cnt is not stable on some HWSKU #16361

Open
bingwang-ms opened this issue Jan 6, 2025 · 1 comment
Open
Labels

Comments

@bingwang-ms
Copy link
Collaborator

Issue Description

We are seeing the test is failing on some testbeds. There are two issues

  1. The test is always using Ethernet0 for test. However, Ethernet0 is admin down on some HWSKU. Like topo_t0. On such devices, the pre_del_cnt and post_del_cnt are always 0, which cause the assert failure.
>       pytest_assert(pre_del_cnt > post_del_cnt,
                      "Number of queue counters count differs from expected")
E       Failed: Number of queue counters count differs from expected
  1. The wait_until is not working perfectly as 60 seconds are not long enough for some low performance device. My suggestion is to change it to 120 seconds, and adding an assert to the result of wait_until like below
pytest_assert(wait_until(120, 20, 0, check_buffer_queues_cnt_cmd_output, ptfhost, gnxi_path,
               dut_ip, iface_to_check, env.gnmi_port), "gnmi server not fully restarted")

Results you see

Test should pass consistently.

Results you expected to see

Test is flaky on some testbeds.

Is it platform specific

generic

Relevant log output

No response

Output of show version

No response

Attach files (if any)

No response

@bingwang-ms
Copy link
Collaborator Author

@arfeigin Can you help take a look at this issue?

@yxieca yxieca added the Triaged label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants