Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snappi]: Replace the dut.shell with dut.command for clear_counter function in common_helpers.py file. #16270

Open
amitpawar12 opened this issue Dec 31, 2024 · 3 comments · May be fixed by #16272

Comments

@amitpawar12
Copy link
Contributor

Issue Description

Function clear_counter has dut.shell used to clear the counters. The shell, however, has in-built sudo usage, and hence needs to be replaced with dut.command to ensure counters with and without sudo are cleared.

Results you see

The SUDO counters are cleared using this function. Needs to be replaced with dut.command.

Results you expected to see

The normal counters (without sudo) and sudo counters needs to be cleared. Right now, only sudo counters are getting cleared.

Is it platform specific

generic

Relevant log output

No response

Output of show version

No response

Attach files (if any)

No response

@yxieca
Copy link
Collaborator

yxieca commented Jan 8, 2025

@sdszhang @developfast for viz.

@yejianquan @wangxin @StormLiangMS can we prevent these scenarios from infrastructure unit tests?

@yxieca
Copy link
Collaborator

yxieca commented Jan 8, 2025

@prsunny @qiluo-msft I am feeling that there might be a gap between the design and test infrastructure. How do we find a way to close/prevent such gap going forward?

@qiluo-msft
Copy link
Contributor

@amitpawar12 Could you explain more details about "The normal counters (without sudo) and sudo counters needs to be cleared". Are you able to reproduce the difference by 2 commands on sonic directly? not by any sonic-mgmt testcase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants