feat: change error logs to info logs

solarmosaic-kflorence · Feb 9, 2019 · 700f699 · 700f699
1 parent b28359f
commit 700f699
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/lib/pact_broker/api/resources/base_resource.rb b/lib/pact_broker/api/resources/base_resource.rb
@@ -127,7 +127,7 @@ def invalid_json?
             JSON.parse(request_body, PACT_PARSING_OPTIONS) #Not load! Otherwise it will try to load Ruby classes.
             false
           rescue StandardError => e
-            logger.error "Error parsing JSON #{e} - #{request_body}"
+            logger.info "Error parsing JSON #{e} - #{request_body}"
             set_json_error_message "Error parsing JSON - #{e.message}"
             response.headers['Content-Type'] = 'application/hal+json;charset=utf-8'
             true

diff --git a/lib/pact_broker/webhooks/job.rb b/lib/pact_broker/webhooks/job.rb
@@ -65,7 +65,7 @@ def handle_failure
           reschedule_job
           update_triggered_webhook_status TriggeredWebhook::STATUS_RETRYING
         else
-          logger.error "Failed to execute webhook #{triggered_webhook.webhook_uuid} after #{retry_schedule.size + 1} attempts."
+          logger.info "Failed to execute webhook #{triggered_webhook.webhook_uuid} after #{retry_schedule.size + 1} attempts."
           update_triggered_webhook_status TriggeredWebhook::STATUS_FAILURE
         end
       end

diff --git a/spec/lib/pact_broker/webhooks/job_spec.rb b/spec/lib/pact_broker/webhooks/job_spec.rb
@@ -118,8 +118,8 @@ module Webhooks
         end
 
         it "logs that it has failed" do
-          allow(Job.logger).to receive(:error)
-          expect(Job.logger).to receive(:error).with(/Failed to execute/)
+          allow(Job.logger).to receive(:info)
+          expect(Job.logger).to receive(:info).with(/Failed to execute/)
           subject
         end