Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slim 5: Ensure that route attributes are always in the Request #3280

Open
akrabat opened this issue Aug 7, 2023 · 2 comments
Open

Slim 5: Ensure that route attributes are always in the Request #3280

akrabat opened this issue Aug 7, 2023 · 2 comments
Labels

Comments

@akrabat
Copy link
Member

akrabat commented Aug 7, 2023

With the way strategies are currently implement, route parameters are only sometimes set into the Request's attributes.

In Slim 5, we should ensure that they are always in there for consistency purposes and that strategies (if we choose to continue with them) only affect the signature of the callable.

@akrabat akrabat added the Slim 5 label Aug 7, 2023
@oddevan
Copy link

oddevan commented Oct 15, 2024

Hi! Read up on Slim over the last weekend and am probably going to use it in my project once I move frameworks. Would love to help out here if I can!

Is the idea behind this issue that the code behind this if statement should in fact run every time? If so, I can pick this up if it's worth tackling.

@odan
Copy link
Contributor

odan commented Oct 19, 2024

This feature will added in Slim 5 as a new Middleware, see here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants