Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relative path might lead to issues when resolving snapshot directory #3

Open
skuzzle opened this issue Sep 17, 2021 · 1 comment
Open

Relative path might lead to issues when resolving snapshot directory #3

skuzzle opened this issue Sep 17, 2021 · 1 comment
Labels
bug Something isn't working component: core component: test-directory-params unconfirmed Questions/bugs that could not be confirmed until now

Comments

@skuzzle
Copy link
Owner

skuzzle commented Sep 17, 2021

The usage of Path.of(...) in DirectoryResolver might lead to issues when the build isn't run directly from its directory or in a multi module project.
@skuzzle skuzzle added the bug Something isn't working label Sep 17, 2021
@skuzzle
Copy link
Owner Author

skuzzle commented Jan 7, 2022

Latest experiments show that this is not necessarily an issue. the following has been tested and observed to be working correctly

  • Running tests from eclipse
  • Running multi module maven build from the root project on windows (where sub modules contain snapshot tests)
  • Running multi module maven build from the root project on linux (where sub modules contain snapshot tests)

@skuzzle skuzzle added the unconfirmed Questions/bugs that could not be confirmed until now label Feb 16, 2022
@skuzzle skuzzle changed the title issue: Relative path might lead to issues when resolving snapshot directory Relative path might lead to issues when resolving snapshot directory Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working component: core component: test-directory-params unconfirmed Questions/bugs that could not be confirmed until now
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@skuzzle