Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing POM directory throws exception instead of creating the default directory #30

Open
sujithpl opened this issue Oct 11, 2016 · 2 comments

Comments

@sujithpl
Copy link

sujithpl commented Oct 11, 2016

I ran into this issue while running a borrowed Gulp file that did not specify the pomDir option. The createAndUploadArtifacts function tries to default it to test/poms and create the directory. But the directoryExists function throws an Exception if the directory does not exist and stops execution.

I think only one of those options should exist - either throw the exception or create the default directory. What does the author @skhatri think? I can submit a pull request depending on your response.

@prashantpalikhe
Copy link

Fixed with #27 ?

@skhatri
Copy link
Owner

skhatri commented Nov 19, 2016

yes, it creates now. part of 0.2 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants