Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] allow to change commit log format in FileHistoryPanel #438

Open
protiumx opened this issue Nov 17, 2023 · 2 comments · May be fixed by #441
Open

[Feature Request] allow to change commit log format in FileHistoryPanel #438

protiumx opened this issue Nov 17, 2023 · 2 comments · May be fixed by #441
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@protiumx
Copy link

protiumx commented Nov 17, 2023 •
edited by sindrets
Loading

Description

I would like to change the commit log format to only show hash and author.
I have tried adding the --pretty flag to the default args for the DiffViewFileHistory but it doesn't work.

default_args {
      DiffviewFileHistory = { "--base=LOCAL" , "--pretty=format..."},
}

Expected behavior

No response

Actual behavior

Log format in the FileHistoryPanel cannot be changed
@protiumx protiumx added the bug Something isn't working label Nov 17, 2023
@sindrets sindrets added enhancement New feature or request and removed bug Something isn't working labels Nov 20, 2023
@sindrets
Copy link
Owner

The --pretty flag is completely unrelated to how info is actually rendered in the plugin panels. We rely on a very specific format internally such that we can parse the log info efficiently.

Allowing customization of the rendered format is possible, but low priority.

If someone wants to work on this just let me know. I can give info about relevant parts of the code, and we can discuss implementation.

@sindrets sindrets added the help wanted Extra attention is needed label Nov 20, 2023
@protiumx protiumx linked a pull request Nov 21, 2023 that will close this issue
Open
@protiumx
Copy link
Author

Hi @sindrets I opened #441 for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add formatting options for file_history_panel protiumx/diffview.nvim
2 participants
@sindrets @protiumx