Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SetRequiredDeep doesn't remove optional modifiers from tuples #1026

Closed
som-sm opened this issue Dec 31, 2024 · 0 comments · Fixed by #1037
Closed

SetRequiredDeep doesn't remove optional modifiers from tuples #1026

som-sm opened this issue Dec 31, 2024 · 0 comments · Fixed by #1037
Assignees
Labels
bug Something isn't working

Comments

@som-sm
Copy link
Collaborator

som-sm commented Dec 31, 2024

Bug description

Refer to the note in this comment.

import {SetRequiredDeep} from "type-fest";

type Test = SetRequiredDeep<{a: [string?]}, "a.0">; // doesn't remove the `?` modifier
//  actual: {a: [string?]} // returns the same thing
//  expected: {a: [string]}

Repro

https://tsplay.dev/NajlBm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant