fstrim and monitoring for disks

[dsseng]

Feature Request

Support periodic FS trimming would not only help bare metal installs, but also thin-provisioned VMs.

hwmon could be useful as well for admins to be able to get CPU/disk/mainboard temperature etc.

Description

Basically the request. Unsure if these can be enabled via extensions, but perhaps these should be available by default, at least discards/fstrim. Maybe this is achievable using stuff like discard=async as well, but some admins use periodic TRIM.

I could possibly develop fstrim stuff if I have time

[onedr0p]

Looks like fstrim can be added as a system extension

https://github.com/siderolabs/extensions?tab=readme-ov-file#tools

There's another issues that touches on your temperature query: #7639

[smira]

Talos already supports some fstrim-related operations on disk wipes. We have some plans for Volume support in Talos, and fstrim might be part of that.

[M4t7e]

It seems trimming is not supported for encrypted volumes. I just used Longhorn with a LUKS2 encrypted volume and tried to trim manually via the Longhorn UI. That responds with this error: unable to trim filesystem for volume test: failed to find valid mountpoint

Discards need to be enabled as they are not by default according to their docs

Enter into the node host the volume is attached to. Enable flag discards for the encrypted volume. The passphrase is recorded in the corresponding secret:

cryptsetup --allow-discards --persistent refresh <Longhorn volume name>

Directly use Longhorn UI to trim the volume or execute fstrim for the mount point of /dev/mapper/ manually.

I thought allow_discards can be enabled with EncryptionConfig.options, but they are only for "additional --perf parameters". Is there any way to enable that for encrypted volumes?

See also: longhorn/longhorn#7836

[onedr0p]

According to the docs looks like xfs_scrub will bring in TRIM support for the OS drive, there's a PR here for Talos.