Skip to content
This repository has been archived by the owner on May 18, 2021. It is now read-only.

Add B1 shimming related functions to +imutils package #147

Open
gaspardcereza opened this issue Jun 22, 2020 · 3 comments
Open

Add B1 shimming related functions to +imutils package #147

gaspardcereza opened this issue Jun 22, 2020 · 3 comments
Assignees

Comments

@gaspardcereza
Copy link
Member

gaspardcereza commented Jun 22, 2020

Context

We want the shimming toolbox to handle B0 and B1 shimming. So far, only B0 shimming was performed but I'm currently working on finding a way to include RF shimming features as we refactor our code.

Objectives

Add functions to perform B1 mapping and shimming to the +imutils package (under +imutils/+b1). These functions will have to be documented following the convention that will be defined in #133.
Unit tests and testing data must also be provided.

@gaspardcereza gaspardcereza self-assigned this Jun 22, 2020
@jcohenadad
Copy link
Member

jcohenadad commented Jun 22, 2020

i would suggest to use lowercase, i.e. +imutils/+b1, as also done for the +b0 package https://github.com/shimming-toolbox/shimming-toolbox/pull/125/files

@gaspardcereza
Copy link
Member Author

i would suggest to use lowercase, i.e. +imutils/+b1, as also done for the +b0 package https://github.com/shimming-toolbox/shimming-toolbox/pull/125/files

I thought you once said that b0 could be misguiding because it could also refer to another term (I can't find the comment though so maybe I just dreamed about it).

@jcohenadad
Copy link
Member

i would suggest to use lowercase, i.e. +imutils/+b1, as also done for the +b0 package https://github.com/shimming-toolbox/shimming-toolbox/pull/125/files

I thought you once said that b0 could be misguiding because it could also refer to another term (I can't find the comment though so maybe I just dreamed about it).

indeed, in the MRI community "b0" often refers to the b-value =0 in DWI experiments. However, in this context, there should not be too much confusion (it is clear we talk about static B0 field), and i find the pros more appealing:

  • sticking to snake-case convention for functions/packages
  • easier to type on the keyboard (no need for SHIFT)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants