Silencing by subscription isn't working again

[bodgit]

This looks like a regression of #689 and seems possibly related to #785

Expected Behavior

Silencing by subscription was fixed in #689 however it doesn't seem to be working again. I've followed the issue reported in #785 and now updated to the latest of both Sensu and Uchiwa packages yet it's still broken.

Current Behavior

The Sensu /silenced endpoint returns what seem valid silences, i.e.

curl localhost:4567/silenced | jq .
[
  ...
  {
    "id": "test:yum",
    "subscription": "test",
    "check": "yum",
    "reason": null,
    "creator": null,
    "begin": null,
    "expire_on_resolve": false,
    "timestamp": 1532356052,
    "expire": 2258194
  },
  ...
]

The Sensu server logs correctly work out the check result is silenced with something like ...,"silenced":true,"silenced_by":["test:yum"]}} logged.

If I follow the logic in the original ticket and create a silence using the redhat:yum subscription then it silences the check correctly and it doesn't bleed into silencing centos:yum as well, which it did do in the original ticket however it doesn't do anything if I use test:yum.

Steps to Reproduce (for bugs)

See #689 for the original setup.

Your Environment

• Uchiwa version used: 1.3.1
• Sensu version used: 1.4.2
• Operating System and version (e.g. Ubuntu 14.04): Red Hat/CentOS EL7