Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIXMEs and TODOs #4

Open
segabor opened this issue Dec 14, 2018 · 1 comment
Open

FIXMEs and TODOs #4

segabor opened this issue Dec 14, 2018 · 1 comment
Labels
umbrella Umbrella ticket

Comments

@segabor
Copy link
Owner

segabor commented Dec 14, 2018

This is an umbrella ticket collecting missing or broken features.

GenSwiftCallExprVisitor

  • GenSwiftCallExprVisitor.visitCallDelegateNode(CallDelegateNode)
  • GenSwiftCallExprVisitor.genObjToPass(CallNode)
  • GenSwiftCallExprVisitor.wrapAsSanitizedContent(SanitizedContentKind, SwiftExpr)
    This can wait until sanitised contents are designed in Soy library.

GenSwiftCodeVisitor

  • visitTemplateDelegateNode
  • visitIfNode generates ugly code if IsComputableAsSwiftExprVisitor enabled for this case.
  • visitSwitchNode needs a full reimplementation
  • visitForNode fix loop variable type inference
  • visitForNonemptyNode ???
  • visitLetContentNode check variable type
  • visitVeLogNode needs implementation

GenSwiftExprsVisitor

  • visitMsgFallbackGroupNode needs a complete rewrite

genSwiftSource

  • genSwiftSource bidi global needs a fix

TranslateToSwiftExprVisitor

  • ERROR field: generate a Swift throw expression
  • visitNullSafeNodeRecurse a lot of null checks are done here. Adapt to actual Soy implementation
  • visitConditionalOpNode needs a fix here.
  • visitCheckNotNullFunction verify feature
  • visitCssFunction missing feature
  • visitXidFunction missing feature
  • visitIsPrimaryMsgInUseFunction requires fix

SwiftExprUtils

  • SWIFT_PRECEDENCES review and fix operator precedences
  • maybeProtect verify feature is required for Swift

SwiftListExpr

  • toSwiftString review implementation

BidiUnicodeWrapDirective, BidiSpanWrapDirective, BidiDirAttrFunction, BidiEndEdgeFunction, BidiGlobalDirFunction

  • applyForSwiftSrc requires Bidi runtime implementation
@segabor segabor added the umbrella Umbrella ticket label Dec 14, 2018
@segabor
Copy link
Owner Author

segabor commented Dec 17, 2018

Above entries reflect only to FIXMEs. TODOs will come soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
umbrella Umbrella ticket
Projects
None yet
Development

No branches or pull requests

1 participant