Improve list iteration #2

segabor · 2018-10-29T19:53:41Z

The following list iteration

{@param names: list<string>}
{for $name in $names}
...
{/for}

compiles to

if let nameList30 = data["names"] {
  for (nameIndex30, nameData30) in nameList30.enumerated() {
  ...
  }
}

which is broken. A possible manual fix is

if let nameList30 = data["names"] as? [String]

Compiler should infer list type from parameter declaration.

The text was updated successfully, but these errors were encountered:

For soy, parsing proto descriptors is a complex multi stage process. 1. parse the binary protos -> FileDescriptorSet protos in memory 2. resolve all the FileDescriptorSet protos against each other 3. index all the messages, enums and extensions to populate the type registry Prior to this CL we were simply doing #1, now we cache the result of #2 as well. This relies on the new SoyInputCache.declaredDependency method to inform the cache how all the objects depend on each other. I explored caching step 3 as well, but this would require creating an entirely new way to construct a SoyTypeRegistry which didn't seem worth it. Instead i just made the indexing code a little more efficient (which should help even in non-worker mode) For worker mode this saves about 15% of the time of a soy compile. GITHUB_BREAKING_CHANGES=none ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=227918474

The addition of @State and default parameters has stretched TemplateVariableManager past its breaking point. It currently has 3 responsibilities 1. creating field definitions 2. managing local variable lifetimes 3. generating save/restore logic The issue is that #1 is for the whole class, #2 is for a single method and #3 is for the render() method. This conflation was fine when the render() method was the only method with any non-trivial logic, but now that we have default parameters and @State initializers we have a desire to generate code for arbitrary soy expressions in the constructor or static initializers. Right now this is just corrupting some debugging metadata, but future changes will cause more issues. This requires us to break up these responsibilities. This is step 1. next will be to extract a mechanism to create temporary variables that is detatched from save/restore state solution. GITHUB_BREAKING_CHANGES=none ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=249533688

segabor self-assigned this Oct 29, 2018

segabor added the bug label Oct 29, 2018

segabor mentioned this issue Oct 29, 2018

Things to fix after first release segabor/VaporSoyTestApp#1

Open

segabor added the expressions label Dec 17, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve list iteration #2

Improve list iteration #2

segabor commented Oct 29, 2018 •

edited

Loading

Improve list iteration #2

Improve list iteration #2

Comments

segabor commented Oct 29, 2018 • edited Loading

segabor commented Oct 29, 2018 •

edited

Loading