feat: support map of files and volumes and mark arrays as deprecated #123
+157
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Meier <[email protected]>
astromechza
force-pushed
the
121-feature-change-array-collections-to-key-value-if-order-is-not-important
branch
from
430ab5e to
0ab272e
Compare
| "type": "object", | ||
| "additionalProperties": false, | ||
| "properties": { | ||
| "target": { |
There was a problem hiding this comment.
Would it be better to not include this here and instead have it part of an allOf in the array version?
Technically, this will validate with target even when using the map version. This could be inconsistent?
There was a problem hiding this comment.
👍 It was a bit more complicated than expected and I needed to use a allOf(not(x), y) to exclude the target property from the object-form.
But it works, and validated against some negative examples.
Signed-off-by: Ben Meier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the feature #121 to support maps of files and objects.
This is done with two changes:
#defssection and remove required target field.