Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature request] Add a default service-port provisioner #64

Closed
mathieu-benoit opened this issue Oct 18, 2024 · 2 comments · Fixed by #70
Closed

[feature request] Add a default service-port provisioner #64

mathieu-benoit opened this issue Oct 18, 2024 · 2 comments · Fixed by #70
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@mathieu-benoit
Copy link
Contributor

Like we have for score-compose and for consistency ("I want to deploy the same Score file with both score-compose and score-k8s"), let's add a default service-port provisioner like this one: https://github.com/score-spec/score-compose/blob/main/internal/command/default.provisioners.yaml#L33.

Source file to update in this repo: https://github.com/score-spec/score-k8s/blob/main/internal/provisioners/default/zz-default.provisioners.yaml.
@mathieu-benoit mathieu-benoit added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Oct 18, 2024
@7h3-3mp7y-m4n 7h3-3mp7y-m4n mentioned this issue Oct 19, 2024
Merged
7 tasks
@lekaf974
Copy link

lekaf974 commented Jan 5, 2025

@mathieu-benoit since the linked PR is merged does this issue fixed ?

@mathieu-benoit mathieu-benoit linked a pull request Jan 6, 2025 that will close this issue
Added a default service-port provisioner #70
Merged
7 tasks
@mathieu-benoit
Copy link
Contributor Author

Good catch, @lekaf974, closing. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added a default service-port provisioner 7h3-3mp7y-m4n/score-k8s
2 participants
@lekaf974 @mathieu-benoit