Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace self-implemented methods with ones from okio #3

Closed
sanyavertolet opened this issue Apr 10, 2023 · 0 comments · Fixed by #10
Closed

Replace self-implemented methods with ones from okio #3

sanyavertolet opened this issue Apr 10, 2023 · 0 comments · Fixed by #10

Comments

@sanyavertolet
Copy link
Member

sanyavertolet commented Apr 10, 2023 •
edited
Loading 

          please create some issue may be on this subject -- refactor/make sure that all existing methods are necessary

          probably, some our methods could be replaced via latest okio methods
          initially, we created them, because they were absent or incorrect in okio,
          but a lot of time have left, may be they fixed these problems

Originally posted by @kgevorkyan in #2 (comment)
@sanyavertolet sanyavertolet mentioned this issue Apr 10, 2023
Merged
sanyavertolet added a commit that referenced this issue Apr 12, 2023
@sanyavertolet
Reuse ProcessBuilder from save-cli
93b956b 
### What's done:
 * replaced myDeleteRecursively with deleteRecursively from okio

(#3)
@sanyavertolet sanyavertolet mentioned this issue Apr 12, 2023
Merged
sanyavertolet added a commit that referenced this issue Apr 12, 2023
@sanyavertolet
Reuse ProcessBuilder from save-cli (#10)
d557a61 
### What's done:
 * replaced myDeleteRecursively with deleteRecursively from okio

(#3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace myDeleteRecursively with deleteRecursively saveourtool/process-builder-multiplatform
1 participant
@sanyavertolet