You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As mentioned in #93 (specifically this comment), both PREP and PyPREP don't flag bad-by-dropout channels as bad or unusable on the first pass before average referencing. The problem with this is that after average referencing, the dropout regions in any bad-by-dropout channels likely aren't going to be completely flat anymore, so they're unable to be detected unless the bad-by-correlation detector manages to flag them.
To fix this, it seems like initial bad-by-dropout channels should be added to the initial noisy channels state here unless matlab_strict is True:
As mentioned in #93 (specifically this comment), both PREP and PyPREP don't flag bad-by-dropout channels as bad or unusable on the first pass before average referencing. The problem with this is that after average referencing, the dropout regions in any bad-by-dropout channels likely aren't going to be completely flat anymore, so they're unable to be detected unless the bad-by-correlation detector manages to flag them.
To fix this, it seems like initial bad-by-dropout channels should be added to the initial noisy channels state here unless
matlab_strict
is True:pyprep/pyprep/reference.py
Lines 219 to 230 in 3625b26
What do you think?
The text was updated successfully, but these errors were encountered: