Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature suggestion] Allow for relevant annotation selection during processing. #133

Open
gael-vanderlee opened this issue Jul 28, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@gael-vanderlee
Copy link

Hello,
When using the pipeline, it would be useful for it to allow for relevant annotations or events that should be considered for channel rejection. Typically, the time between trial should be ignored, and I have annotations that encompass relevant time periods. More commonly, researchers use mne's epochs to find relevant portions of their data.
Rejecting channels outside of those time periods is irrelevant.

This joins #108. I'm not sure why PREP doesn't support discontinuities, but if that's a limitation that we can circumvent we definitely should.

@sappelhoff
Copy link
Owner

Very late reply, but I totally agree in principle, and this is sort of a duplicate of #108.

I think a few discontinuities in the signal would probably not mess with the noisy channel finding algorithms.

@sappelhoff sappelhoff added the enhancement New feature or request label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants