@rustbot claim

@weihanglo looks like #14755 doesnt fix it, i can pick it up

This below is a test snapshot for current behavior, Cargo will ignore the --pacakge flags due to it prefers the workspace option

    p.cargo("check --package baz --workspace")
        .with_stderr_data(str![[r#"
[FINISHED] `dev` profile [unoptimized + debuginfo] target(s) in [ELAPSED]s

"#]])
        .run();

    p.cargo("check --package nonexistence --workspace")
        .with_stderr_data(str![[r#"
[CHECKING] baz v0.1.0 ([ROOT]/foo/baz)
[CHECKING] foo v0.1.0 ([ROOT]/foo)
[FINISHED] `dev` profile [unoptimized + debuginfo] target(s) in [ELAPSED]s

"#]])
        .run();

IMO, If --package and --workspace both were specified, In this case, warn --package nonexistence will be ignored much better than warn --package nonexistence didn't match.

IMO, If --package and --workspace both were specified, In this case, warn --package nonexistence will be ignored much better than warn --package nonexistence didn't match.

I disagree. The warning would only be about the --package being redundant. The user expressed an intent with --package nonexistent and we should warn, or even error, if that intent was not satisfied.

For myself, I feel like non-existent packages should probably be an error, rather than a warning,. That would be a change in behavior but I think we can chalk it up to a bug. If we feel a transition period is needed, we could start as a warning.

The user expressed an intent with --package nonexistent and we should warn, or even error, if that intent was not satisfied.

Yes I agree it.

The warning would only be about the --package being redundant.

IMO, I think it would be good to also add this warning -workspace will be selected and ignored -package if they passed in the same time. Or we could add this description in somewhere (Cargo book or the --help).