Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 'static' naming #229

Open
bradennapier opened this issue Jul 11, 2017 · 2 comments
Open

Change 'static' naming #229

bradennapier opened this issue Jul 11, 2017 · 2 comments

Comments

@bradennapier
Copy link

bradennapier commented Jul 11, 2017

the naming for static conflicts with the keyword static which i keep running into linting problems etc as it does not at all like that.

import { static as Immutable } from 'seamless-immutable'

this does appear to work but for example with flow you can not use static ANYWHERE

image

I am sure there are other places where this conflict will come into play in order to use the library in the recommended manner.

Perhaps instead something like

import { seamless as Immutable } from 'seamless-immutable'
// or
import { StaticImmutable } from 'seamless-immutable'
// or
import { I } from 'seamless-immutable' // supah short 

or similar?

I would imagine you can keep the static export but would be good to have some sort of other option to use other than the static naming to do this.

@bradennapier
Copy link
Author

Err yeah what's more is this basically completely breaks flow and the entire app - seamless-immutable can not go with flow when using the recommended way or every single file is an error automatically :(

@akread
Copy link

akread commented Dec 11, 2017

Maybe we can export it under the alias functional or fp? From what I've seen that is pretty standard in community packages that have a functional version of their code.

For backwards compatibility it could be exported under static as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants