Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: hidden inputs are not masked when maskAllInputs is enabled #1609

Open
1 task done
ababik opened this issue Dec 16, 2024 · 1 comment
Open
1 task done

[Bug]: hidden inputs are not masked when maskAllInputs is enabled #1609

ababik opened this issue Dec 16, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@ababik
Copy link
Contributor

ababik commented Dec 16, 2024

Preflight Checklist

  • I have searched the issue tracker for a bug report that matches the one I want to file, without success.

What package is this bug report for?

rrweb

Version

2.0.0-alpha.18

Expected Behavior

All hidden input values are expected to be masked if maskAllInputs option is enabled.

Actual Behavior

The values are recorded as is which is a potential privacy issue.

Steps to Reproduce

  1. Add a hidden input to a page and set some value
  2. Start session recording with maskAllInputs: true
  3. Inspect recorded data and you can see that the value is not masked

Testcase Gist URL

No response

Additional Information

No response
@ababik ababik added the bug Something isn't working label Dec 16, 2024
@ababik ababik mentioned this issue Dec 16, 2024
Open
@ababik
Copy link
Contributor Author

ababik commented Dec 16, 2024

Submitted a pull request to address the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ababik