Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rqt_plot loses configuration on startup #229

Closed
trainman419 opened this issue May 23, 2014 · 6 comments
Closed

rqt_plot loses configuration on startup #229

trainman419 opened this issue May 23, 2014 · 6 comments

Comments

@trainman419
Copy link
Contributor

When starting up, if rqt_plot can't find a topic, it silently ignores it and removes it from the configuration. This causes two problems:

  • If you try to rely on the RQT framework to persist your plotting settings, they will silently be removed if the publisher isn't active when rqt_plot restarts
  • If you start rqt_plot with a list of topics, any topics from the command line that don't exist are silently ignored

Note that any solution to this should also be aware of the changes that were made to fix #110

It might be worth trying:

  • Maintaining internal configuration even if topics don't exist - possibly including topic types
  • Not blocking startup on missing topics
  • occasionally polling to see if missing topics have appeared
  • failing startup if topics/fields specified on the command line don't exist
@ablasdel
Copy link
Contributor

I think the silently removing topics was a quick fix to solve the "block until it is published" bug.
The proposed "Occasional polling" seems like a more elegant solution to the issue.

@DorianScholz
Copy link
Member

A possible solution to this problem and #106 might be to maintain a list of recently plotted topics.
These could be offered to the user in a drop down menu of the "+" button similar to the "-" button.
This list should contain previously plotted topics, which were not available at start up, as well as topics removed via the "-" button, thus allowing for easy toggling of topics.
But there needs to be an option to remove topics from this list, either manually maybe in the settings dialog, or automatically after a certain time that a topic has not been plotted (requiring a list with "last used" timestamps).

@ablasdel
Copy link
Contributor

ablasdel commented Jun 6, 2014

@trainman419 can you detail what you did in the demo you showed me here? It was pretty solid. possibly with screen shots?

@trainman419
Copy link
Contributor Author

@ablasdel I don't think I demo'd this issue for you. Perhaps you meant #236 or #239 ?

@ablasdel
Copy link
Contributor

ablasdel commented Jun 6, 2014

My mistake I thought this was covered by #239 as well since you handled switching between back-ends. My brain extended that to plug-in start-up which clearly isn't the case. Retracted!

@dirk-thomas
Copy link
Contributor

This issue was moved to ros-visualization/rqt_plot#4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants