You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I would like to be able to apply feedback to a marker sooner than 1 second after it has been created. This is currently blocked by
# if two callers try to modify the same marker, reject (timeout= 1 sec)
if marker_context.last_client_id != feedback.client_id \
and (rospy.Time.now() - marker_context.last_feedback).to_sec() < 1.0:
rospy.logdebug("Rejecting feedback for ...
because of how marker_context.last_feedback and marker_context.last_client_id are initialized.
This also means that any markers created while sim_time is paused will never get feedback until sim_time is unpaused. My use case here is pausing a bag file and using interactive markers to annotate some data.
If I understand correctly, this could be fixed by initializing market_context.last_feedback to zero, or explicitly checking for last_client_id = ""
Happy to create a PR if you're supportive of this change!
Best,
Erik
The text was updated successfully, but these errors were encountered:
Hello!
I would like to be able to apply feedback to a marker sooner than 1 second after it has been created. This is currently blocked by
because of how
marker_context.last_feedback
andmarker_context.last_client_id
are initialized.This also means that any markers created while sim_time is paused will never get feedback until sim_time is unpaused. My use case here is pausing a bag file and using interactive markers to annotate some data.
If I understand correctly, this could be fixed by initializing
market_context.last_feedback
to zero, or explicitly checking forlast_client_id = ""
Happy to create a PR if you're supportive of this change!
Best,
The text was updated successfully, but these errors were encountered: