Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails parsing browserhacks CSS #173

Open
iamvdo opened this issue Jul 9, 2014 · 2 comments
Open

Fails parsing browserhacks CSS #173

iamvdo opened this issue Jul 9, 2014 · 2 comments

Comments

@iamvdo
Copy link

iamvdo commented Jul 9, 2014

Rework fails at parsing CSS from browserhacks:

http://browserhacks.com/css/browserhacks.css

PostCSS is doing better (only two fails on .sel { (;background: lightgreen;); } and .sel{ [;background: lightgreen;]; }

Plus, error messages are not fully understandable:

{CSS} has no method 'charAt' at comment (node_modules\rework\node_modules\css\lib\parse\index.js:161:20)
    at comments (node_modules\rework\node_modules\css\lib\parse\index.js:147:16)
    at rules (node_modules\rework\node_modules\css\lib\parse\index.js:109:5)
    at stylesheet (node_modules\rework\node_modules\css\lib\parse\index.js:80:16)
    at module.exports (node_modules\rework\node_modules\css\lib\parse\index.js:557:20)
    at rework (node_modules\rework\index.js:26:21)
    at Object.<anonymous> (app.js:7:30)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
@MoOx
Copy link
Contributor

MoOx commented Jul 9, 2014

Thanks for reporting ;)

@ai
Copy link
Contributor

ai commented Jul 9, 2014

Issue is not only in this CSS case. Rework needs same integration tests with production CSS and with god hacks list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants