Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log level changes are not visible in lower level libraries #641

Open
bioothod opened this issue Aug 16, 2015 · 0 comments
Open

Log level changes are not visible in lower level libraries #641

bioothod opened this issue Aug 16, 2015 · 0 comments
Labels

Comments

@bioothod
Copy link
Member

When elliptics log level is changed (for example via dnet_ioclient -r addr:port:family -M debug), it only affects elliptics logger.

And while eblob (lower level library) uses the same blackhole logger, it has internal log-level field, which is never updated after eblob initialization. Eblob's log-level field is being set in dnet_blob_config_init() only. Eblob checks whether current log level allows new message to be printed, and while blackhole would print new message (its log level has changed), it is not called, since eblob's own log level hasn't changed.

There are 2 ways to fix this:

  1. update eblob and never check its internal log-level, it will only exist in ABI as unused field, and all log-level related checks will happen in blackhole logger
  2. propagate log-level changes into eblob internal logger's field, when elliptics' log-level is being changed. This is noticeably simpler solution, although not aesthetically pure.
@bioothod bioothod added the bug label Aug 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant