Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ext/price-code #173

Closed
opoudjis opened this issue Oct 29, 2024 · 3 comments
Closed

Add ext/price-code #173

opoudjis opened this issue Oct 29, 2024 · 3 comments
Assignees
@andrew2net
Labels
enhancement New feature or request

Comments

@opoudjis
Copy link
Contributor

opoudjis commented Oct 29, 2024 •
edited
Loading

ext/price-code is included in relaton-iec. As I have just stumbled on with metanorma/metanorma-iso#1217, Price Codes are also a characteristic of ISO standards; for example ISO 2074:2007/Amd.1:2017(E) has in its colophon the Price Code A. So I am also adding ext/price-code to relaton-iso; it should be processed in the same way as in relaton-iec.
@opoudjis opoudjis added the enhancement New feature or request label Oct 29, 2024
@opoudjis opoudjis assigned opoudjis and andrew2net and unassigned opoudjis Oct 29, 2024
@opoudjis opoudjis mentioned this issue Oct 29, 2024
Closed
@andrew2net
Copy link
Contributor

@opoudjis as we already have price-code in relaton-iec I will move it to the common model implementation in relaton-iso-bib. And since it's rendered as root element in YAML I won't change this behavior until we have major Relaton update. Is it ok?

andrew2net added a commit to relaton/relaton-iso-bib that referenced this issue Oct 31, 2024
@andrew2net
add price-code relaton/relaton-iso#173
a821dbd
@andrew2net
Copy link
Contributor

Fixed in relaton-iso-bib v1.192

@opoudjis
Copy link
Contributor Author

Yes and yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrew2net andrew2net

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@opoudjis @andrew2net