Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] React v19 Support #6574

Open
aress31 opened this issue Dec 12, 2024 · 4 comments
Open

[FEAT] React v19 Support #6574

aress31 opened this issue Dec 12, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@aress31
Copy link

aress31 commented Dec 12, 2024

Is your feature request related to a problem? Please describe.

When upgrading my project to React v19. Refine yields the following peer deps errors:

npm warn Found: @types/[email protected]
npm warn node_modules/@types/react
npm warn   dev @types/react@"^19.0.1" from the root project
npm warn   26 more (@mui/private-theming, @mui/system, @mui/types, ...)
npm warn
npm warn Could not resolve dependency:
npm warn peer @types/react@"^17.0.0 || ^18.0.0" from @refinedev/[email protected]
npm warn node_modules/@refinedev/core
npm warn   @refinedev/core@"^4.56.0" from the root project
npm warn   5 more (@refinedev/mui, @refinedev/react-hook-form, ...)
npm warn ERESOLVE overriding peer dependency
npm warn While resolving: [email protected]
npm warn Found: @types/[email protected]
npm warn node_modules/@types/react
npm warn   dev @types/react@"^19.0.1" from the root project
npm warn   26 more (@mui/private-theming, @mui/system, @mui/types, ...)
npm warn
npm warn Could not resolve dependency:
npm warn peer @types/react@"^17.0.0 || ^18.0.0" from @refinedev/[email protected]
npm warn node_modules/@refinedev/core
npm warn   @refinedev/core@"^4.56.0" from the root project
npm warn   5 more (@refinedev/mui, @refinedev/react-hook-form, ...)
npm warn ERESOLVE overriding peer dependency
npm warn While resolving: [email protected]
npm warn Found: @types/[email protected]
npm warn node_modules/@types/react
npm warn   dev @types/react@"^19.0.1" from the root project
npm warn   26 more (@mui/private-theming, @mui/system, @mui/types, ...)
npm warn
npm warn Could not resolve dependency:
npm warn peer @types/react@"^17.0.0 || ^18.0.0" from @refinedev/[email protected]
npm warn node_modules/@refinedev/core
npm warn   @refinedev/core@"^4.56.0" from the root project
npm warn   5 more (@refinedev/mui, @refinedev/react-hook-form, ...)
npm warn ERESOLVE overriding peer dependency
npm warn While resolving: [email protected]
npm warn Found: @types/[email protected]
npm warn node_modules/@types/react
npm warn   dev @types/react@"^19.0.1" from the root project
npm warn   26 more (@mui/private-theming, @mui/system, @mui/types, ...)
npm warn
npm warn Could not resolve dependency:
npm warn peer @types/react@"^17.0.0 || ^18.0.0" from @refinedev/[email protected]
npm warn node_modules/@refinedev/core
npm warn   @refinedev/core@"^4.56.0" from the root project
npm warn   5 more (@refinedev/mui, @refinedev/react-hook-form, ...)
npm warn ERESOLVE overriding peer dependency
npm warn While resolving: [email protected]
npm warn Found: @types/[email protected]
npm warn node_modules/@types/react
npm warn   dev @types/react@"^19.0.1" from the root project
npm warn   26 more (@mui/private-theming, @mui/system, @mui/types, ...)
npm warn
npm warn Could not resolve dependency:
npm warn peer @types/react@"^17.0.0 || ^18.0.0" from @refinedev/[email protected]
npm warn node_modules/@refinedev/react-router-v6
npm warn   @refinedev/react-router-v6@"^4.6.0" from the root project
npm warn ERESOLVE overriding peer dependency
npm warn While resolving: [email protected]
npm warn Found: @types/[email protected]
npm warn node_modules/@types/react-dom
npm warn   dev @types/react-dom@"^19.0.2" from the root project
npm warn   5 more (@refinedev/core, @refinedev/devtools-internal, ...)
npm warn
npm warn Could not resolve dependency:
npm warn peer @types/react-dom@"^17.0.0 || ^18.0.0" from @refinedev/[email protected]
npm warn node_modules/@refinedev/react-router-v6
npm warn   @refinedev/react-router-v6@"^4.6.0" from the root project
npm warn ERESOLVE overriding peer dependency
npm warn While resolving: [email protected]
npm warn Found: [email protected]
npm warn node_modules/react
npm warn   react@"^19.0.0" from the root project
npm warn   49 more (@emotion/react, @emotion/styled, ...)
npm warn
npm warn Could not resolve dependency:
npm warn peer react@"^17.0.0 || ^18.0.0" from @refinedev/[email protected]
npm warn node_modules/@refinedev/mui
npm warn   @refinedev/mui@"^5.22.0" from the root project
npm warn ERESOLVE overriding peer dependency
npm warn While resolving: [email protected]
npm warn Found: [email protected]
npm warn node_modules/react
npm warn   react@"^19.0.0" from the root project
npm warn   49 more (@emotion/react, @emotion/styled, ...)
npm warn
npm warn Could not resolve dependency:
npm warn peer react@"^17.0.0 || ^18.0.0" from @refinedev/[email protected]
npm warn node_modules/@refinedev/react-router-v6
npm warn   @refinedev/react-router-v6@"^4.6.0" from the root project
npm warn ERESOLVE overriding peer dependency
npm warn While resolving: [email protected]
npm warn Found: [email protected]
npm warn node_modules/react
npm warn   react@"^19.0.0" from the root project
npm warn   49 more (@emotion/react, @emotion/styled, ...)
npm warn
npm warn Could not resolve dependency:
npm warn peer react@"^18" from @toolpad/[email protected]
npm warn node_modules/@toolpad/core
npm warn   @toolpad/core@"^0.10.0" from the root project
npm warn ERESOLVE overriding peer dependency
npm warn While resolving: [email protected]
npm warn Found: [email protected]
npm warn node_modules/react
npm warn   react@"^19.0.0" from the root project
npm warn   49 more (@emotion/react, @emotion/styled, ...)
npm warn
npm warn Could not resolve dependency:
npm warn peer react@"^18.3.1" from [email protected]
npm warn node_modules/react-dom
npm warn   react-dom@"^19.0.0" from the root project
npm warn   20 more (@floating-ui/react-dom, @mui/x-charts, ...)
npm warn ERESOLVE overriding peer dependency
npm warn While resolving: [email protected]
npm warn Found: [email protected]
npm warn node_modules/react
npm warn   react@"^19.0.0" from the root project
npm warn   49 more (@emotion/react, @emotion/styled, ...)
npm warn
--- SNIP ---

Describe alternatives you've considered

No response

Additional context

No response

Describe the thing to improve

Migrating to Refine to React v19.

@aress31 aress31 added the enhancement New feature or request label Dec 12, 2024
@aress31 aress31 changed the title [FEAT] React 19 Support [FEAT] React v19 Support Dec 12, 2024
@BatuhanW
Copy link
Member

@aress31 thanks for the issue. We'll plan it release in the future.

@aress31
Copy link
Author

aress31 commented Dec 13, 2024

@BatuhanW, no prob. As a side note, when I uograded my project today, there is a warning about a peer dep for notistack for Refine MUI. This is something you may want to have a look at. 😊

@BatuhanW
Copy link
Member

@aress31 can you send more details? We'll look into it. We did the upgrade locally and the required changes were minimal, since we've already fixed most of the deprecations at 18.

@aress31
Copy link
Author

aress31 commented Dec 13, 2024

@BatuhanW, see:

npm warn ERESOLVE overriding peer dependency
npm warn While resolving: [email protected]
npm warn Found: @mui/[email protected]
npm warn node_modules/@mui/material
npm warn   @mui/material@"^6.2.0" from the root project
npm warn   8 more (@mui/icons-material, @mui/lab, @mui/x-charts, ...)
npm warn
npm warn Could not resolve dependency:
npm warn peer @mui/material@"^5.0.0" from [email protected]
npm warn node_modules/notistack
npm warn   notistack@"^2.0.4" from @refinedev/[email protected]
npm warn   node_modules/@refinedev/mui
npm warn
npm warn Conflicting peer dependency: @mui/[email protected]
npm warn node_modules/@mui/material
npm warn   peer @mui/material@"^5.0.0" from [email protected]
npm warn   node_modules/notistack
npm warn     notistack@"^2.0.4" from @refinedev/[email protected]
npm warn     node_modules/@refinedev/mui

The notistack import within @refinedev\mui\src\providers\notificationProvider\index.tsx is likely the culprit.

EDIT: That is the latest version of notistack: https://github.com/iamhosseindhv/notistack/releases/tag/v3.0.1. The 2.0.8 seems quite outdated. Maybe worth a dep bump?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants