Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cglm_vec4_ucopy not defined inside cglm/mat2.h #425

Open
m4reQ opened this issue Jul 23, 2024 · 1 comment
Open

cglm_vec4_ucopy not defined inside cglm/mat2.h #425

m4reQ opened this issue Jul 23, 2024 · 1 comment

Comments

@m4reQ
Copy link

m4reQ commented Jul 23, 2024

Function glm_mat2_copy from cglm/mat2.h internally uses glm_vec4_ucopy, defined inside cglm/vec4.h, which is not included. THis leads to symbol not being found.
Minimal example:

#include <cglm/mat2.h>

void foo() {
    mat2 x, y;
    glm_mat2_copy(x, y);
}

This will result in a error LNK2019: unresolved external symbol _glm_vec4_ucopy referenced in function _glm_mat2_copy on MSVC.

A simple solution for this is to just add #include <cglm/vec4.h> into the cglm/mat2.h file.

@recp
Copy link
Owner

recp commented Aug 1, 2024

Hi @m4reQ,

Sorry for the delay and thanks for the solution.

I think we should check other headers too and fix all related issues.

A PR would be nice otherwise I can fix this asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants