Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry on failed request to bank #128

Open
yoyostile opened this issue Apr 13, 2017 · 1 comment
Open

Retry on failed request to bank #128

yoyostile opened this issue Apr 13, 2017 · 1 comment

Comments

@yoyostile
Copy link
Contributor

We could use something like https://github.com/nfedyashev/retryable.
Would be great to fix this.

@bumi
Copy link
Contributor

bumi commented Sep 5, 2017

How should this be done? Do we want to do that automatically or should this be a configuration option and somehow be transparent to the user.

I am a bit worried about some unintended side-effects (whatever could happen if we send the request twice). Does the API consumer somehow need to be informed about a potential failed request and its response?
Generally I'd see this more of a client responsibility. A ebics box client wrapper could for example retry sending the request to the box in case of an error.

thoughts?

@bumi bumi added the discuss label Sep 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants