Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undefined method superviseesfor nil #430

Open
wdiechmann opened this issue Nov 27, 2024 · 2 comments
Open

undefined method superviseesfor nil #430

wdiechmann opened this issue Nov 27, 2024 · 2 comments
Assignees

Comments

@wdiechmann
Copy link

https://github.com/rails/solid_queue/blame/c521c6d47d10abeaf076a81d9af29e80eb2b11c7/lib/solid_queue/supervisor.rb#L174

probably should look something like process&.supervisees.find_by... or

if registered_process = process.supervisees.find_by(name: terminated_fork.name) rescue false
@rosa
Copy link
Member

rosa commented Nov 28, 2024

Huh, yes, but I'm curious to know when you reach this line with process being nil 🤔 In theory, this should never be executed before the supervisor has been registered. I must be missing a scenario where this might happen, but not sure what it'd be. Do you have more context about when you hit this?

@wdiechmann
Copy link
Author

I got the background job to work - 99% thx to you - and then I let it rip for a few hours - and once I got back to my desk, the log told me that there where no supervisees hanging out with the nil process 😉

I'll make sure to try to sample better context when this happens again - if it does

@rosa rosa self-assigned this Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants