Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release empty Rack 2 compatible version. #15

Closed
lsylvester opened this issue Sep 13, 2022 · 5 comments
Closed

Release empty Rack 2 compatible version. #15

lsylvester opened this issue Sep 13, 2022 · 5 comments

Comments

@lsylvester
Copy link

As per the suggestion at rack/rack#1805 (comment) - it would be good to have a version of rack-session that is compatible with rack 2.0.

In particular - I am looking at how Sidekiq can relax its dependency on rack to allow for upgrading to rack 3. While rack-session is only compatible with rack >= 3.0 - we are not able to add rack-session as a dependency so that it can be included in all of the applications.

By providing an empty rack-session gem that is compatible with rack 2 - we allow gems to specify a dependency on rack-session and maintain compatibility with rack 2 and 3 transparently to the application developers.

I have prepared a branch that I think should be able to be used to build and publish a v0.1.1 version of the gem at main...lsylvester:rack-session:v0.1.1 (I have not made this as a PR as it should not be merged).

@dentarg
Copy link
Contributor

dentarg commented Dec 15, 2022

@ioquatix this sounds like a good idea (I know we touched on it over at sinatra/sinatra) although I don't have a particular use-case for it right now (haven't found the opportunity to dive into trying to make Sinatra work with Rack 3)

@ioquatix
Copy link
Member

Okay, v1 release of rack-session will be for rack < 3, and v2 release will be for rack 3+.

@ioquatix
Copy link
Member

Okay this is all released. v1.0.0 is Rack < 3 and v2.0.0 is Rack >= 3.

@ioquatix
Copy link
Member

The same is now also true for the rackup gem.

@pboling
Copy link

pboling commented Dec 1, 2023

The README for stable-v1 branch, and shipping in the actual v1 gem, is incorrectly telling people to add require "rack/session", which will blow up since that file doesn't exist in either the rack v2 gem or the rack-session v1 gem. Reported as #27.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants