Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider how hard it would be to allow Inf / -Inf #317

Open
DavisVaughan opened this issue Apr 5, 2023 · 0 comments
Open

Consider how hard it would be to allow Inf / -Inf #317

DavisVaughan opened this issue Apr 5, 2023 · 0 comments
Labels
feature a feature request or enhancement

Comments

@DavisVaughan
Copy link
Member

For time points, could follow the duckdb approach of using INT64_MAX/MIN as special infinity values
https://github.com/duckdb/duckdb/blob/8edeaf41a6a683d9df84d609a4f7660ef5f8d8d9/src/include/duckdb/common/types/timestamp.hpp#L79-L88

For calendars, could define that if year = max_year + 1, then that is considered infinity? Similar with negative infinity. This could possibly work because the max year is defined to be 32767 due to the use of a short for year, but we store our year in an int due to having to be compatible with R. Since all calendar types have a year field, 32767 + 1 could be infinity?

After figuring out how the storage would work, then it would be a matter of fixing the print method and adding special support everywhere to ensure propagation is working as expected. Not easy!

@DavisVaughan DavisVaughan added the feature a feature request or enhancement label Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement
Projects
None yet
Development

No branches or pull requests

1 participant