Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline mode #1026

Merged
merged 31 commits into from
Jan 1, 2025
Merged

Inline mode #1026

merged 31 commits into from
Jan 1, 2025

Conversation

thejackshelton
Copy link
Collaborator

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests
  • Other

Why is it needed?

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have ran pnpm change and documented my changes
  • I have add necessary docs (if needed)
  • Added new tests to cover the fix / functionality

Copy link

changeset-bot bot commented Dec 16, 2024

⚠️ No Changeset found

Latest commit: 6666e97

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Dec 16, 2024

Open in Stackblitz

npm i https://pkg.pr.new/qwikifiers/qwik-ui@1026
npm i https://pkg.pr.new/qwikifiers/qwik-ui/@qwik-ui/headless@1026
npm i https://pkg.pr.new/qwikifiers/qwik-ui/@qwik-ui/utils@1026
npm i https://pkg.pr.new/qwikifiers/qwik-ui/@qwik-ui/styled@1026

commit: b5fda89

Copy link

cloudflare-workers-and-pages bot commented Jan 1, 2025

Deploying qwik-ui-site with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6666e97
Status: ✅  Deploy successful!
Preview URL: https://4ffc52a1.qwik-ui-site.pages.dev
Branch Preview URL: https://preview.qwik-ui-site.pages.dev

View logs

@thejackshelton thejackshelton merged commit a4a64f9 into main Jan 1, 2025
2 checks passed
@thejackshelton thejackshelton deleted the combobox-inline branch January 1, 2025 17:29
TheMcnafaha pushed a commit to TheMcnafaha/qwik-ui that referenced this pull request Jan 8, 2025
* fix cls

* inline setup

* test setup

* inline mode functionality

* makes sure input value doesn't change

* support custom filter search

* fix a11y

* initial search

* styles

* cmd k

* initial search

* fix combobox empty bug

* search links

* fix highlighted navigation

* add pagefind in public to gitignore

* more docs

* refactor: make search fit in with make it yours

* refactor: use search instead of debounced search

* feat: add data-pagefind-body to include only relevant content

* refactor: change pagefind generation scripts

* chore(test.yml): add pagefind generation script on CI workflow

* refactor: remove /apps/website/public/pagefind/ from gitignore and ignore more specific paths

* chore: re-generate pagefind output

* refactor(styled combobox): add Inline and Empty components

* refactor(search): use styled modal and combobox

* refactor(scrollbar): change styles

* chore: add data-pagefind-ignore to code snippets + generate

* better results

* improved

* refactor

* remove debug tasks

---------

Co-authored-by: maiieul <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants