Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Requests from digitalegarage #60

Open
Elyytscha opened this issue Jan 9, 2025 · 0 comments
Open

Feature Requests from digitalegarage #60

Elyytscha opened this issue Jan 9, 2025 · 0 comments

Comments

@Elyytscha
Copy link

Elyytscha commented Jan 9, 2025

Hello, as you may have noticed or not, we forked your repo, as we needed some features: https://github.com/digitalegarage/argocd-diff-action?tab=readme-ov-file#config-we-added

It would be really awesome if we could implement this features (without breaking your actual needed behaviour of the action) upstream, the following features can be implemented like we did imo, as we have taken care to no break your actual logic. Also we didn't changed your defaults.

          # Allows to customize if the Diff should be collapsed in the github comment
          collapse-diff: false
          # Sets Timezone
          timezone: America/Los_Angeles
          # Sets Presentation of the date
          timezone-locale: en-US
          # sets the diff tool which will be used in the argocd diff command
          diff-tool: diff -N -u

the feature which enables:
tracking-label: argocd.argoproj.io/instance
in actual state may be a breaking change, this would need some rework i think. basically this logic.
image

master...digitalegarage:argocd-diff-action:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant