Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accommodate stroke width in getD #3

Open
jdanyow opened this issue May 14, 2022 · 1 comment
Open

Accommodate stroke width in getD #3

jdanyow opened this issue May 14, 2022 · 1 comment

Comments

@jdanyow
Copy link

jdanyow commented May 14, 2022

Hey! Thanks for sharing this lib, it's awesome 🤙

I noticed the apex of the stroke tends to be clipped. It's noticeable when it occurs in the middle of the sparkline. What do you think about adding some logic to getD to accommodate the stroke width?

CleanShot 2022-05-14 at 16 20 45@2x

CleanShot 2022-05-14 at 16 21 42@2x
@jdanyow
Copy link
Author

jdanyow commented May 14, 2022

(happy to open a PR by the way)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jdanyow