Larger than 0 for ECN #308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #307
martinduke
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
This is Editorial, but even if threshold==0, we're acking anyway so the qualifier isn't really necessary.
I might also add a sentence saying that this changes the advice in RFC 9000 Section 13.2.1, which is to immediately ACK every CE packet. This is probably important for reviewers to understand.
Whether you take my advice or not, LGTM.
| @@ -444,7 +444,7 @@ a Reordering Threshold of 2. | |||
|
|
|||
| ## Expediting Explicit Congestion Notification (ECN) Signals {#congestion} | |||
|
|
|||
| If the Ack-Eliciting Threshold is larger than 1, an endpoint SHOULD send | |||
| If the Ack-Eliciting Threshold is larger than 0, an endpoint SHOULD send | |||
There was a problem hiding this comment.
Suggested change
| If the Ack-Eliciting Threshold is larger than 0, an endpoint SHOULD send | |
| Regardless of the Ack-Eliciting Threshold, an endpoint SHOULD send |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #307