-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace macro with just code for structure builders #195
Comments
/bounty $200 |
|
/attempt #195 I am interested to work on this issue.
|
/attempt #195 Options |
/attempt #195
|
/attempt #195 Options |
💡 @palash25 submitted a pull request that claims the bounty. You can visit your bounty board to reward. |
🎉🎈 @palash25 has been awarded $240! 🎈🎊 |
* Replace macro generated builder types with unrolled ones Fixes: #195 * fix clippy and implement missing defaults * unexpose builder module and remove comment --------- Co-authored-by: generall <[email protected]>
Currently we use macro definitions to auto-generate code for structure builders, which looks like this:
https://github.com/qdrant/rust-client/blob/master/src/qdrant.rs#L9606
But usage of macros makes navigation in the project harder.
qdrant.rs
file is generated using code from here https://github.com/qdrant/rust-client/blob/master/tests/protos.rs#L173 (yes, in test 🤷♂️ )I propose to abandon macros and use hand-written code instead. It would be easier to write a whole new definition of the builder than to understand how generator works.
To do this, I think we need to
In order to make sure friction-less transition, we need to make sure all test snippets are still valid without changing: https://github.com/qdrant/rust-client/tree/master/tests/snippet_tests
The text was updated successfully, but these errors were encountered: