Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Use Fix #2

Open
Teque5 opened this issue Dec 7, 2022 · 1 comment
Open

Default Use Fix #2

Teque5 opened this issue Dec 7, 2022 · 1 comment

Comments

@Teque5
Copy link

Teque5 commented Dec 7, 2022

  • Current implementation doesn't produce any output in the svg with no arguments. Specifically you have to add -b to produce valid output. Maybe remove this switch.
  • set marker generator as executable
  • first line should be #!/usr/bin/env python3 to run on any system
  • Dictionaries up to 5X5 work for me. 6X6 and 7X7 get this error:
Total marker size is going to be 600mm
Ground Sampling Distance is a maximum of 10.4mm/pixels, fly accordingly
Your marker has been created and is available here ./6X6_100_0.svg .
Traceback (most recent call last):
  File "./marker_generator.py", line 699, in <module>
    generate_marker(marker_id)
  File "./marker_generator.py", line 382, in generate_marker
    svg.add(createPixels(svg, bits, datawidth, border, margin, white_color))
  File "./marker_generator.py", line 287, in createPixels
    if not border or bits[i * datawidth + j]:
IndexError: list index out of range
  • Dictionary arg should call 'upper' so that using "5x5_100" and "5X5_100" both work.
@gromain
Copy link
Collaborator

gromain commented Mar 21, 2023

Hey,

I didn't see your comment before. Thanks for your input, I'll keep this open and integrate a fix for your suggestions.

I suspect there is an issue with the availability of the 7x7 and 6x6 dictionaries, I'll dig into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants