Fix wrong event loop reference with mixed scoped tests #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…two wider-scoped tests. The event_loop fixture finalizers only close event loops that were not created by pytest-asyncio. This prevents the finalizers from accidentally closing a module-scoped loop, for example.
…the more generic "__pytest_asyncio" magic attribute.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1029 +/- ##
==========================================
- Coverage 91.42% 91.10% -0.33%
==========================================
Files 2 2
Lines 548 562 +14
Branches 72 74 +2
==========================================
+ Hits 501 512 +11
- Misses 28 30 +2
- Partials 19 20 +1 ☔ View full report in Codecov by Sentry. |
asvetlov
approved these changes
Dec 30, 2024
|
Thanks for having a look! I agree that the code is really complex. It takes hours to debug even simple changes and understand We really made an effort to keep backwards compatibility, so that made the situation worse. Maybe we should start following through with all the deprecations that were introduced and start cleaning up the code. |
seifertm
deleted the
fix-wrong-event-loop-reference-with-mixed-scoped-tests
branch
seifertm
restored the
fix-wrong-event-loop-reference-with-mixed-scoped-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #950 describes a problem with tests that have mixed event loop scopes. When a function-scoped loop is executed in between two tests with wider loop scope, the tests after the function-scoped tests reference the wrong event loop.
This is caused by the implementation of the event_loop fixture and its finalizers. This PR addresses the issue twofold:
Fixes #950