Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt "sentinel" pattern in this repo #1257

Open
blampe opened this issue Jan 2, 2025 · 1 comment
Open

Adopt "sentinel" pattern in this repo #1257

blampe opened this issue Jan 2, 2025 · 1 comment
Labels
kind/engineering Work that is not visible to an external user

Comments

@blampe
Copy link
Contributor

blampe commented Jan 2, 2025

Some commits were recently merged despite failing checks because we were missing a branch protection for "deploy/update_workflows".

https://github.com/pulumi/ci-mgmt/commits/master/

We should adopt the "sentinel" pattern in this repo's workflows, so we only need to specify one requirement in the UI and then that thing can be managed via code.

@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Jan 2, 2025
@guineveresaenger
Copy link
Contributor

While managing this type of thing with code will help, I also believe that whenever we change important repo settings, we should log this in an issue.

Code is not a stand-in for a bug or decision log.

@guineveresaenger guineveresaenger removed the needs-triage Needs attention from the triage team label Jan 2, 2025
@mjeffryes mjeffryes added the kind/engineering Work that is not visible to an external user label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/engineering Work that is not visible to an external user
Projects
None yet
Development

No branches or pull requests

4 participants