Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] #67

Closed
kiranrega opened this issue Jan 23, 2023 · 5 comments
Closed

[IMPROVEMENT] #67

kiranrega opened this issue Jan 23, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@kiranrega
Copy link

kiranrega commented Jan 23, 2023

What improvement are you suggesting?

with out reloading the web page by click on that button we assign click event redirect to that starting page.

Why should make this improvement?

user no need to got to reload.

How can we make these improvements?

simply by routing

Additional Context

if it is not suitable update please update me i am a beginner.

@kiranrega kiranrega added the enhancement New feature or request label Jan 23, 2023
@github-actions
Copy link

Thanks for raising this issue & giving your bit in this project's development 😇

@prakhartiwari0
Copy link
Owner

Can you explain what you want to do?

@singhimat99
Copy link
Contributor

Every time you refresh after interacting with something on the page, the browser shows a popup asking the user to confirm the refresh:
Screen Shot 2023-01-31 at 3 54 51 PM

I believe kiranrega is suggesting that the browser automatically refreshes without the popup.

I looked into this and noticed the default behavior of the window.onbeforeunload event was altered in the main.js file, so this may be an intended feature you might not want to change.

If the above is not the intended behaviour I would love to work on this issue.

@prakhartiwari0
Copy link
Owner

Hey, @singhimat99 thanks for explaining the issue. Actually, I have put that code to ask before reloading to prevent users from losing progress, as I noticed a lot of times people click on the back button on mobile or close the tab on the desktop which erases their progress of the test if they did so while giving the test.
Therefore, to prevent this from happening, I have temporarily created this ask message before reloading or exiting so that the progress is not lost accidentally.

But as I said this is a temporary feature, and it will be removed once we merge these two PRs soon: #53 and #72. The issue for addressing this problem is #33 & #70 respectively.

I hope I was able to explain, feel free to ask any questions.

Happy Contributing!

@prakhartiwari0
Copy link
Owner

Also @kiranrega if you are also understanding this issue, then you may describe further if you want something else. Or if the issue is the same, you may close this one because it's not needed and similar issues are already open and people are working on them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants