Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"ingest:git:..." fails if aimed at a submodule with relocated data dir #16

Open
warpfork opened this issue Jan 4, 2020 · 0 comments
Open

Comments

@warpfork
Copy link
Member

warpfork commented Jan 4, 2020

tl;dr if the git repo you try to ingest has a .git file instead of the full dir there, it fails.

Which is fairly common behavior for submodules in recent versions of git (anything newer than ~2015ish, iirc) -- the git data dir is relocated under .git/modules of the parent repo, and a .git file in the submodule points towards that.

Apparently git.PlainOpen(pathstr) (at least at our currently linked version of the relevant libraries) doesn't account for this case...?

(This may be tangentially related to, or involve the same knowledge as, polydawn/rio#9 -- the essence of the issue is we really need to take a long hard look at all the 'open' functions this library provides and figure out which ones do the right things. Or at worst, if it so happens that none of them do and we need to push some patches upstream.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant