Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only store email body vs. complete markup in test data #4753

Open
birkjernstrom opened this issue Jan 2, 2025 · 0 comments
Open

Only store email body vs. complete markup in test data #4753

birkjernstrom opened this issue Jan 2, 2025 · 0 comments
Labels
dx Efforts to enhance developer experience for creators

Comments

@birkjernstrom
Copy link
Member

notifications and magic_link store their complete email markup in testdata from POLAR_TEST_RECORD including the footer containing current year - requiring a new generation on January 1st each year...

Instead, we should and could store only the body of the email markup in the testdata and use Jinja2 fully to generate a full markdown template with all of the surrounding CSS and footer (with a dynamic year).
@birkjernstrom birkjernstrom added the dx Efforts to enhance developer experience for creators label Jan 2, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Backlog Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dx Efforts to enhance developer experience for creators
Projects
Backlog
Status: Backlog
Polar
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@birkjernstrom