You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A page will have Page.Rotate, which is the variable, and page.rotate(), which is our wrapper around QPDFPageObjectHelper::rotatePage.
It might be more intuitive for .rotate to be a property, like the various bounding boxes are, or to rename .rotate to something like .apply_rotation() since it has parameters.
The text was updated successfully, but these errors were encountered:
jbarlow83
changed the title
Page.rotate is weird
Page.rotate API is potentially confusing/violates expectations
May 14, 2023
Looking at the various boxes, to me the intuitive solution would be to have a rotate property where the getter uses getAttribute to get the effective /Rotate and the setter uses the existing rotate with relative = False, with a separate rotate_relative method.
The really intuitive solution would be to have a Rotate object and implement relative rotation as an augmented assignment, i.e as page.rotate += 90 or page.rotate -= 90, although this feels like a bit of overkill.
A page will have Page.Rotate, which is the variable, and page.rotate(), which is our wrapper around QPDFPageObjectHelper::rotatePage.
It might be more intuitive for .rotate to be a property, like the various bounding boxes are, or to rename .rotate to something like .apply_rotation() since it has parameters.
The text was updated successfully, but these errors were encountered: