Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Packaging of unmaintained dependency: http-parser #2536

Closed
jcoyne opened this issue Apr 17, 2024 · 2 comments · Fixed by #2535
Closed

Packaging of unmaintained dependency: http-parser #2536

jcoyne opened this issue Apr 17, 2024 · 2 comments · Fixed by #2535

Comments

@jcoyne
Copy link

jcoyne commented Apr 17, 2024

Passenger appears to package http-parser (https://github.com/phusion/passenger/blob/stable-6.0/src/cxx_supportlib/ServerKit/http_parser.cpp) , which has been abandoned by it's maintianers: nodejs/http-parser#522. This may be a risk as there is no one to handle security issues. It's unclear if Passenger is affected by https://nvd.nist.gov/vuln/detail/CVE-2020-8287, but it seems like it is.
@CamJN
Copy link
Member

CamJN commented Apr 17, 2024

@jcoyne #2535

@jcoyne
Copy link
Author

jcoyne commented Apr 17, 2024

@CamJN Excellent! I missed that.

@CamJN CamJN linked a pull request Apr 17, 2024 that will close this issue
Replace HTTP parser with llhttp #2535
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace HTTP parser with llhttp phusion/passenger
2 participants
@jcoyne @CamJN