Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventsConfig.createSiteParsers(): split the logic #804

Closed
0pdd opened this issue Jan 2, 2018 · 2 comments
Closed

EventsConfig.createSiteParsers(): split the logic #804

0pdd opened this issue Jan 2, 2018 · 2 comments

Comments

@0pdd
Copy link

0pdd commented Jan 2, 2018

The puzzle 801-71f4f89c from #801 has to be resolved:

// @todo #801 EventsConfig.createSiteParsers(): split the logic for properties
// parsing and the object instantiation

The puzzle was created by Slava Semushin on 02-Jan-18.

@0pdd 0pdd added the techdebt label Jan 2, 2018
0pdd referenced this issue Jan 2, 2018
Fix #801

No functional changes.
@php-coder
Copy link
Owner

The idea is to parse properties, put them in a Map<String, String> and pass it to builder that will create a fully-initialized object. It separates logic and also allows us to remove setField() and isFullyInitialized from SiteParser interface.

This also could solve ModifiedCyclomaticComplexity warning from PMD.

@php-coder php-coder changed the title EventsConfig.createSiteParsers(): split the logic for properties parsing and the object... EventsConfig.createSiteParsers(): split the logic Jan 3, 2018
@php-coder php-coder self-assigned this Dec 4, 2018
@php-coder php-coder added this to the 0.4 milestone Dec 4, 2018
@php-coder
Copy link
Owner

We won't have such log after migrating site parsers configuration to database (see #975)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants