Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate unit tests away from Spock to JUnit back #1246

Open
29 tasks
php-coder opened this issue Jan 26, 2020 · 4 comments
Open
29 tasks

Migrate unit tests away from Spock to JUnit back #1246

php-coder opened this issue Jan 26, 2020 · 4 comments
Assignees
@php-coder
Labels
ADR/needed A decision has been made and it needs to be documented area/unit tests impact/changelog This change should be reflected in the NEWS.txt file in progress refactoring
Milestone
next

Comments

@php-coder
Copy link
Owner

php-coder commented Jan 26, 2020 •
edited
Loading

Rationale:

TODO:

  • SlugUtilsTest
  • LocaleUtilsTest
  • PagerTest
  • SeriesSalesServiceImplTest
  • CatalogUtilsTest
  • StampsCatalogServiceImplTest
  • SeriesSalesImportServiceImplTest
  • SeriesInfoExtractorServiceImplTest
  • TimedSeriesInfoExtractorServiceTest
  • SeriesImportServiceImplTest
  • SeriesServiceImplTest
  • CollectionServiceImplTest
  • CategoryServiceImplTest
  • ParticipantServiceImplTest
  • FilesystemImagePersistenceStrategyTest
  • ImageServiceImplTest
  • TimedImagePreviewStrategyTest
  • DatabaseImagePersistenceStrategyTest
  • SiteServiceImplTest
  • CronServiceImplTest
  • SuspiciousActivityServiceImplTest
  • UsersActivationServiceImplTest
  • UserServiceImplTest
  • CountryServiceImplTest
  • Remove plugin, dependencies, build logic, Danger support, update editorconfig
  • Close Groovy/Spock-related issues
  • Update README/NEWS
  • remove dependency on junit-jupiter-engine and exclude (and ban?) junit from other dependencies
  • remove a comment for Danger: highlight a failed spock test #761
@php-coder php-coder added this to the 0.4.3 milestone Jan 26, 2020
@php-coder php-coder self-assigned this Jan 26, 2020
@php-coder php-coder added impact/changelog This change should be reflected in the NEWS.txt file ADR/needed A decision has been made and it needs to be documented in progress labels Jan 26, 2020
@php-coder php-coder mentioned this issue Jan 27, 2020
Open
3 tasks
@php-coder
Copy link
Owner Author

Heh, Spring Security has been also migrated away of Groovy: spring-projects/spring-security#4939

@php-coder php-coder modified the milestones: 0.4.3, 0.5, 0.4.4 Mar 13, 2020
@php-coder php-coder modified the milestones: 0.4.4, next Apr 3, 2020
@php-coder
Copy link
Owner Author

Good comparison: https://blog.solidsoft.pl/2020/04/15/spock-vs-junit-5-the-ultimate-feature-comparison/

@php-coder php-coder modified the milestones: next, 0.4.5 Dec 2, 2020
@php-coder php-coder modified the milestones: 0.4.5, 0.4.6 Dec 22, 2020
@php-coder php-coder mentioned this issue Dec 26, 2020
Open
50 tasks
@php-coder
Copy link
Owner Author

Perhaps we can use @TestTemplate -- https://www.baeldung.com/junit5-test-templates

php-coder added a commit that referenced this issue Jan 2, 2021
@php-coder
refactor: migrate unit tests (on Java) to JUnit 5
d84daee 
Notes:
- only unit tests already written on Java have been migrated. Tests on Spock will be migrated in #1246
- pmd: JUnit4SuitesShouldUseSuiteAnnotation check has been disabled because it's junit3/4 specific
- pmd: JUnitAssertionsShouldIncludeMessage check has been disabled because we use AssertJ assestions

Changelogs:
- https://junit.org/junit5/docs/5.0.0/user-guide/#release-notes
- https://junit.org/junit5/docs/5.1.0/release-notes/index.html
- https://junit.org/junit5/docs/5.2.0/release-notes/index.html
- https://junit.org/junit5/docs/5.3.2/release-notes/index.html

Fix #1160
@php-coder
Copy link
Owner Author

https://www.arhohuttunen.com/junit-5-mockito/

@php-coder php-coder modified the milestones: 0.4.6, 0.4.7 Feb 14, 2021
@php-coder php-coder modified the milestones: 0.4.7, 0.4.8 Mar 2, 2023
@php-coder php-coder mentioned this issue Jul 26, 2023
Closed
@php-coder php-coder removed this from the 0.4.8 milestone Dec 29, 2023
@php-coder php-coder added this to the 0.4.9 milestone Dec 29, 2023
@php-coder php-coder mentioned this issue Feb 9, 2024
Open
71 tasks
@php-coder php-coder modified the milestones: 0.4.9, next Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
ADR/needed A decision has been made and it needs to be documented area/unit tests impact/changelog This change should be reflected in the NEWS.txt file in progress refactoring
Projects
None yet
Milestone
next
Development

No branches or pull requests
1 participant
@php-coder