Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from Travis CI to GitHub Actions #1154

Closed
php-coder opened this issue Nov 15, 2019 · 3 comments
Closed

Migrate from Travis CI to GitHub Actions #1154

php-coder opened this issue Nov 15, 2019 · 3 comments
Assignees
Labels
ADR/needed A decision has been made and it needs to be documented area/build scripts area/infrastructure impact/changelog This change should be reflected in the NEWS.txt file
Milestone

Comments

@php-coder
Copy link
Owner

php-coder commented Nov 15, 2019

Plan:

  • Run CheckStyle
    • run only: when *.java, *.properties, pom.xml, src/main/config/checkstyle.xml or src/main/config/checkstyle-suppressions.xml, .github/workflows/static-analysis.yml, src/main/scripts/execute-command.sh files were modified
    • run always: on prod branch
  • Run PMD
    • run only: when *.java, pom.xml, src/main/config/pmd.xml, .github/workflows/static-analysis.yml, src/main/scripts/execute-command.sh files were modified
    • run always: on prod branch
  • Check license header
    • run only: when *.java, *.groovy, src/main/config/license_header.txt, .github/workflows/static-analysis.yml, src/main/scripts/execute-command.sh files were modified
    • run always: on prod branch
  • Check pom.xml
    • run only: when pom.xml, .github/workflows/static-analysis.yml, src/main/scripts/execute-command.sh files were modified
    • run always: on prod branch
  • Run bootlint
    • run only: when src/main/**/*.html, .github/workflows/static-analysis.yml, src/main/scripts/execute-command.sh files were modified
    • run always: on prod branch
  • Run rflint
    • run only: when src/test/robotframework/**/*.robot, .github/workflows/static-analysis.yml, src/main/scripts/execute-command.sh files were modified
    • run always: on prod branch
  • Run shellcheck
    • check also: infra/vagrant/provisioning/roles/mystamps-backup/templates/remote-backup.sh
    • run only: when .github/workflows/static-analysis.yml, src/main/scripts/**/*.sh files were modified
    • run always: on prod branch
  • Run jest
    • check also: src/main/frontend/package.json and src/main/frontend/package-lock.json
    • try to cache: Downloading https://nodejs.org/dist/v10.16.0/node-v10.16.0-linux-x64.tar.gz to /home/runner/.m2/repository/com/github/eirslett/node/10.16.0/node-10.16.0-linux-x64.tar.gz
    • run only: when *.js, pom.xml, .github/workflows/unit-tests.yml files were modified
    • run always: on prod branch
  • Run html5validator
  • Run enforcer maven plugin
    • run only: when pom.xml, .github/workflows/static-analysis.yml, src/main/scripts/execute-command.sh files were modified
    • run always: on prod branch
  • Run unit tests
    • run only: when *.java, *.groovy, pom.xml, .github/workflows/unit-tests.yml, src/main/scripts/execute-command.sh files were modified
    • run always: on prod branch
  • Run CodeNarc
    • run only: when *.groovy, pom.xml, .github/workflows/static-analysis.yml, src/main/scripts/execute-command.sh files were modified
    • run always: on prod branch
  • Run SpotBugs
    • run only: when *.java, pom.xml, src/main/config/spotbugs-filter.xml, .github/workflows/static-analysis.yml, src/main/scripts/execute-command.sh files were modified
    • run always: on prod branch
  • Run ansible-lint
    • run only: when src/main/scripts/ci/ansible/deploy.yml, infra/vagrant/provisioning/**/*.yml, .github/workflows/static-analysis.yml, src/main/scripts/execute-command.sh files were modified
    • run always: on prod branch
  • Run integration tests
    • on H2
    • on MySQL
    • on PostgreSQL
      • add a healthcheck (pg_isready)
  • Run Danger (only for PRs) (no needed: Discontinue usage of Danger #1600)
  • deploy on production server
  • remove gh1154_github_actions branch
  • remove .travis.yml
  • update NEWS.txt
  • update a badge (example: https://github.com/nackjicholson/aiosql)
  • decide on "travis" profile
  • update other places (git grep -i travis)
  • maven: filter out Downloading messages (https://stackoverflow.com/questions/21638697/disable-maven-download-progress-indication and https://stackoverflow.com/a/55781461/352708)
  • think about how to save robot framework reports in case of failure
  • revise Travis-related issues:
  • implement diagram generation in generated-assets branch
  • ensure that pipelines are running for PRs (on: [ push, pull_request ])
  • save (see actions/upload-artifact) robot framework result as an artifact (in case of failure: if: ${{ failure() }})
  • try to cache ~/.m2 folder with all dependencies
  • for master branch only (pom.xml, <script>.sh): generate a list of differences in versions between us and Spring Boot
  • publish code coverage to a separate branch (github pages?)
  • export MAVEN_OPTS='-Xss256k' (see https://maven.apache.org/configure.html)
  • Travis: remove a webhook and app
  • Travis: remove VAULT_PASSWORD (https://app.travis-ci.com/github/php-coder/mystamps/settings)

See:

@php-coder
Copy link
Owner Author

Video: https://youtu.be/QoCSvwkP_lQ 🇷🇺

@php-coder php-coder modified the milestones: 0.5, next Apr 3, 2020
@php-coder php-coder changed the title Consider migration from Travis CI to GitHub Actions Migrate from Travis CI to GitHub Actions Nov 29, 2022
@php-coder php-coder modified the milestones: next, 0.4.7 Nov 29, 2022
@php-coder
Copy link
Owner Author

Travis CI has stopped to work: Builds have been temporarily disabled for public repositories due to a negative credit balance. I had 10000 credits and they have been used. Also I can't use OSS credits: You have used 0 of your 0 monthly credits

@php-coder php-coder added the impact/changelog This change should be reflected in the NEWS.txt file label Dec 3, 2022
php-coder added a commit that referenced this issue Dec 3, 2022
php-coder added a commit that referenced this issue Dec 3, 2022
…html5validator to fix the build on TravisCI"

This reverts commit 0e09fac.

During migration to GitHub Actions (#1154), in commit 661444c we
have started to use containers with Ubuntu 20.04 that has Python 3.8.10 so this workaround isn't
needed anymore.

Relate to #1533
php-coder added a commit that referenced this issue Dec 3, 2022
@php-coder
Copy link
Owner Author

Also I can't use OSS credits: You have used 0 of your 0 monthly credits

I have contacted with support and got 25k credits. Travis is working now.

php-coder added a commit that referenced this issue May 25, 2023
php-coder added a commit that referenced this issue May 28, 2023
php-coder added a commit that referenced this issue May 28, 2023
…o GitHub Actions

This change also equals PostgreSQL versions between docker compose and CI and hence fixes #1141

Part of #1154
php-coder added a commit that referenced this issue Jun 5, 2023
php-coder added a commit that referenced this issue Jul 21, 2023
php-coder added a commit that referenced this issue Jul 21, 2023
When we remove execution of the integration tests (mvn verify), we also miss that it was creating
WAR file that is used during deployment.

Correction for 6003e01 commit.

Relate to #1154
php-coder added a commit that referenced this issue Jul 24, 2023
php-coder added a commit that referenced this issue Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ADR/needed A decision has been made and it needs to be documented area/build scripts area/infrastructure impact/changelog This change should be reflected in the NEWS.txt file
Projects
None yet
Development

No branches or pull requests

1 participant