Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maven-pmd-plugin: stop using deprecated rules #1018

Closed
Tracked by #1669
php-coder opened this issue May 2, 2019 · 0 comments
Closed
Tracked by #1669

maven-pmd-plugin: stop using deprecated rules #1018

php-coder opened this issue May 2, 2019 · 0 comments
Assignees
@php-coder
Labels
area/build scripts resolution/gone Non-reproducible, obsolete, outdated issues techdebt
Milestone
0.4.8

Comments

@php-coder
Copy link
Owner

After updating PMD some warnings left:

[WARNING] Discontinue using Rule name category/java/codestyle.xml/AbstractNaming as it is scheduled for removal from PMD. PMD 7.0.0 will remove support for this Rule.
[WARNING] Discontinue using Rule name category/java/codestyle.xml/AvoidPrefixingMethodParameters as it is scheduled for removal from PMD. PMD 7.0.0 will remove support for this Rule.
[WARNING] Discontinue using Rule name category/java/codestyle.xml/ForLoopsMustUseBraces as it is scheduled for removal from PMD. PMD 7.0.0 will remove support for this Rule.
[WARNING] Discontinue using Rule name category/java/codestyle.xml/IfElseStmtsMustUseBraces as it is scheduled for removal from PMD. PMD 7.0.0 will remove support for this Rule.
[WARNING] Discontinue using Rule name category/java/codestyle.xml/IfStmtsMustUseBraces as it is scheduled for removal from PMD. PMD 7.0.0 will remove support for this Rule.
[WARNING] Discontinue using Rule name category/java/codestyle.xml/SuspiciousConstantFieldName as it is scheduled for removal from PMD. PMD 7.0.0 will remove support for this Rule.
[WARNING] Discontinue using Rule name category/java/codestyle.xml/VariableNamingConventions as it is scheduled for removal from PMD. PMD 7.0.0 will remove support for this Rule.
[WARNING] Discontinue using Rule name category/java/codestyle.xml/WhileLoopsMustUseBraces as it is scheduled for removal from PMD. PMD 7.0.0 will remove support for this Rule.
[WARNING] Discontinue using Rule name category/java/design.xml/ModifiedCyclomaticComplexity as it is scheduled for removal from PMD. PMD 7.0.0 will remove support for this Rule.
[WARNING] Discontinue using Rule name category/java/design.xml/NcssConstructorCount as it is scheduled for removal from PMD. PMD 7.0.0 will remove support for this Rule.
[WARNING] Discontinue using Rule name category/java/design.xml/NcssMethodCount as it is scheduled for removal from PMD. PMD 7.0.0 will remove support for this Rule.
[WARNING] Discontinue using Rule name category/java/design.xml/NcssTypeCount as it is scheduled for removal from PMD. PMD 7.0.0 will remove support for this Rule.
[WARNING] Discontinue using Rule name category/java/multithreading.xml/UnsynchronizedStaticDateFormatter as it is scheduled for removal from PMD. PMD 7.0.0 will remove support for this Rule.

Tech debt for: 65bb553 (#1014)
@php-coder php-coder added this to the 0.4 milestone May 2, 2019
@php-coder php-coder self-assigned this May 2, 2019
@php-coder php-coder modified the milestones: 0.4, 0.5, 0.4.1 May 25, 2019
php-coder added a commit that referenced this issue Jul 24, 2019
@php-coder
chore(pmd.xml): remove (deprecated) AvoidPrefixingMethodParameters rule.
53b6f8e 
First it's deprecated (see #1018).
Second, it blocks me to merge fix for #1098 because it complains on inCollection variable that is
totally readable to me.

[skip ci]
@php-coder php-coder modified the milestones: 0.4.1, 0.5 Aug 27, 2019
@php-coder php-coder modified the milestones: 0.5, 0.4.2 Sep 9, 2019
@php-coder php-coder modified the milestones: 0.4.2, next Nov 6, 2019
@php-coder php-coder modified the milestones: next, 0.4.3 Dec 4, 2019
@php-coder php-coder modified the milestones: 0.4.3, 0.5 Mar 13, 2020
@php-coder php-coder modified the milestones: 0.5, next Apr 3, 2020
@php-coder php-coder modified the milestones: next, 0.4.7 Jul 2, 2021
php-coder added a commit that referenced this issue Jul 2, 2021
@php-coder
chore(pmd): replace deprecated Ncss*Count PMD's rules by the NcssCount
40150b1 
Quote from https://pmd.github.io/2017/12/15/PMD-6.0.0/
%
The new Java rule NcssCount (category design) replaces the three rules “NcssConstructorCount”,
“NcssMethodCount”, and “NcssTypeCount”. The new rule uses the metrics framework to achieve the
same. It has two properties, to define the report level for method and class sizes separately.
Constructors and methods are considered the same.
%

Part of #1018

[skip ci]
php-coder added a commit that referenced this issue Jul 2, 2021
@php-coder
chore(pmd): replace deprecated *MustUseBraces PMD's rules by the Cont…
4b6361d 
…rolStatementBraces

Quote from https://pmd.github.io/2018/03/26/PMD-6.2.0/#deprecated-rules
%
The Java rules WhileLoopMustUseBraces, ForLoopMustUseBraces, IfStmtMustUseBraces, and
IfElseStmtMustUseBraces are deprecated. They will be replaced by the new rule
ControlStatementBraces, in the category codestyle.
%

Part of #1018
php-coder added a commit that referenced this issue Jul 2, 2021
@php-coder
chore(pmd): remove deprecated AbstractNaming rule
00efc12 
Quote from https://pmd.github.io/2018/04/29/PMD-6.3.0/#deprecated-rules
%
The Java rule AbstractNaming (java-codestyle) is deprecated in favour of ClassNamingConventions.
%

See also https://pmd.github.io/2018/04/29/PMD-6.3.0/#naming-rules-enhancements

Part of #1018
@php-coder php-coder modified the milestones: 0.4.7, 0.5 Oct 18, 2021
@php-coder php-coder mentioned this issue Feb 9, 2024
Closed
62 tasks
@php-coder php-coder modified the milestones: 0.5, 0.4.8 Feb 25, 2024
@php-coder php-coder added the resolution/gone Non-reproducible, obsolete, outdated issues label Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
area/build scripts resolution/gone Non-reproducible, obsolete, outdated issues techdebt
Projects
None yet
Milestone
0.4.8
Development

No branches or pull requests
1 participant
@php-coder