From 6af463b3cd5079e14f0883b94e096ba420331822 Mon Sep 17 00:00:00 2001 From: Slava Semushin Date: Fri, 9 Feb 2024 23:33:49 +0700 Subject: [PATCH] ci: decommission of html5validator The following issue won't be fixed: Closes #541 Closes #760 Part of #1669 --- .github/workflows/static-analysis.yml | 15 --------------- src/main/scripts/execute-command.sh | 20 -------------------- 2 files changed, 35 deletions(-) diff --git a/.github/workflows/static-analysis.yml b/.github/workflows/static-analysis.yml index 0a4c7e533..30d17e1d8 100644 --- a/.github/workflows/static-analysis.yml +++ b/.github/workflows/static-analysis.yml @@ -130,21 +130,6 @@ jobs: - name: Run shellcheck run: ./src/main/scripts/execute-command.sh shellcheck - run-html5validator: - name: Run html5validator - # https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idruns-on - runs-on: ubuntu-20.04 - steps: - - name: Clone source code - uses: actions/checkout@v4.1.1 # https://github.com/actions/checkout - with: - # Whether to configure the token or SSH key with the local git config. Default: true - persist-credentials: false - - name: Install html5validator - run: pip3 install --user html5validator==0.4.2 - - name: Run html5validator - run: ./src/main/scripts/execute-command.sh html5validator - run-ansible-lint: name: Run ansible-lint # https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idruns-on diff --git a/src/main/scripts/execute-command.sh b/src/main/scripts/execute-command.sh index f10d289a4..d90a02294 100755 --- a/src/main/scripts/execute-command.sh +++ b/src/main/scripts/execute-command.sh @@ -52,25 +52,6 @@ case ${1:-} in --batch-mode \ enforcer:enforce ;; - 'html5validator') - # FIXME: remove ignoring of error about alt attribute after resolving #314 - # @todo #109 Check src/main/config/nginx/503.*html by html5validator - # @todo #695 /series/import/request/{id}: use divs instead of table for elements aligning - exec html5validator \ - --root "$ROOTDIR/src/main/webapp/WEB-INF/views" \ - --no-langdetect \ - --ignore-re \ - 'Attribute “(th|sec|togglz|xmlns):[a-z]+” not allowed' \ - 'Attribute “th:[-a-z]+” not allowed on element "body" at this point' \ - 'Attribute “(th|sec|togglz):[-a-z]+” is not serializable' \ - 'Attribute with the local name “xmlns:[a-z]+” is not serializable' \ - --ignore \ - 'An "img" element must have an "alt" attribute' \ - 'Element "option" without attribute "label" must not be empty' \ - 'The "width" attribute on the "td" element is obsolete' \ - 'Attribute "loading" not allowed on element "img" at this point' \ - --show-warnings - ;; 'integration-tests') exec "$MVN" \ --batch-mode \ @@ -127,7 +108,6 @@ case ${1:-} in echo >&2 '- checkstyle' echo >&2 '- codenarc' echo >&2 '- enforcer' - echo >&2 '- html5validator' echo >&2 '- integration-tests' echo >&2 '- jest' echo >&2 '- pmd'